feat: directory mounting supports bind and volume modes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Would you kindly add test coverage for this change? |
There are currently two errors in the part, but I haven't made any changes, so I can't solve it. Can you help me to solve it? |
|
@lavie I have solved these two problems here. In the latest docker:
|
|
@lavie Now the test should pass perfectly. |
lavie
reviewed
Jul 9, 2024
|
continued in #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old code, using
Config.VolumesandHostConfig.Bindsto get volume can only display volume mounts in bind mode normally.I changed it to get the volume through the
Mountsdata string, so that bothbindandvolumemounting can be obtained normally.[ { "Id": "81da5acdde68bc319ebdcf306112ee7b2ba3ad9fd5105a2aeea1bd3d00c042ba", "Mounts": [ { "Type": "bind", "Source": "/xxxx/data", "Destination": "/xxxx/data", "Mode": "rw", "RW": true, "Propagation": "rprivate" }, { "Type": "volume", "Name": "31528af375053362a6b7f74650cfc8c39b22808af111581190d8efd30c47aee5", "Source": "/xxx/volumes/31528af375053362a6b7f74650cfc8c39b22808af111581190d8efd30c47aee5/_data", "Destination": "/xxxx/data", "Driver": "local", "Mode": "rw", "RW": true, "Propagation": "" } ] } ]